[chirp_devel] [PATCH] Fix more string-related errors #495

[Dan Smith]

Hi Alex,

> # HG changeset patch
> # User Alex Page <a.t.page at gmail.com>
> # Date 1592155249 14400
> #      Sun Jun 14 13:20:49 2020 -0400
> # Branch py3
> # Node ID 628ead8b23cb1b1181e98355e87b1681ce4922ff
> # Parent  8831ed2fd44de57b6177ce0d47ebd5530b8f3256
> Fix more string-related errors #495

I appreciate these too, however, I think that these conversions need to be done per-driver in a holistic sense. Having done a lot of them myself already, I think these "by violation" changes are less useful than "by driver". The reason for that is that if you just make the changes that cause the driver to import without failure, or seem to run without as real radio to test for, it's harder for us to track which ones have actually been converted to py3. Almost *all* of the drivers I've done have non-superficial changes required to make them work on py3 (specifically unicode and bytes changes in the clone routines) which have only really been uncovered by the actual testing of the driver with a real radio.

Thus, I've avoided applying these wide-sweeping changes to just fix linter-level superficial python3 syntax issues because it just means we import the driver, expose it in the UI, users assume it works, and then have it fail during clone or actual use.

Thanks for understanding,

--Dan