[chirp_devel] Patch ft4.py restructure, #7615

[Bernhard Hailer]

Thanks Dan,

Sorry for the problems. Not sure how the patch itself became corrupted. 
A working theory is that Thunderbird sent the patch as HTML - the 
patchbomb method is probably safer, indeed.

I'll send it tonight using the patchbomb mechanism (it works, I used it 
before). There is currently only this one patch, disregard all others. 
Once this patch is applied, I will submit a series more.


Thanks and 73,
Bernhard

On 03-Feb-20 16:34, Dan Smith via chirp_devel wrote:
>> # HG changeset patch
>> # User Bernhard Hailer <ham73tux at gmail.com>
>> # Date 1580597959 28800
>> #      Sat Feb 01 14:59:19 2020 -0800
>> # Node ID 04404b4e386b95acfe95b590af75d9f26619d0ba
>> # Parent  53cd045bbf8253d32b43a528b245caff243e4c02
>> While implementing two more radios of the Yaesu FT-4 family (the FT-25,
>> see #7543, and the FT-4V, see #7387), I found that with some moderate
>> reorganization, implementation of new radios will become easier. The
>> proposed reorganization implements one more interstitial layer of
>> inheritance to support the sub families of FT-4 (containing the FT-4X
>> and FT-4V) and FT-65 (containing FT-65 and FT-25). Also, some variable
>> assignments have been moved from the individual radio classes to the
>> SCU-35 base class and to the interstitial classes named above.
>>
>> This change also adds the infrastructure for adding European or Asian
>> models, and as such prepare for addressing a number of currently open
>> issues (6.25kHz tune step issues on EU models, frequency limitations;
>> see #6619, #6651, #6677, #6761, #6869). It will also make it easier for
>> a few additional fixes for issues which were found during my work on
>> this driver (#7601, #7603, #7605). I will submit these fixes in
>> additional patches.
> This makes sense to me.
>
> This patch doesn't apply for me as lines are wrapped and other user-agent-related mangleage, which isn't usually a problem with your stuff. If you know what's wrong, can you re-send it, and if not maybe attach it for encapsulation? I definitely prefer inline when I can get it, but only if the user agent isn't going to mangle it :)
>
> Note that the patchbomb extension lets you send straight from hg without these problems, if that's an option for you:
>
> https://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess#Setting-up-GMail-for-patchbomb-email
>
> Anyway, I've lost track of which things should apply in which order, so if you can send me a clean copy of this reorg patch, as well as the things that should go on it in the right order I'll get to that.
>
> Thanks!
>
> --Dan
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20200203/0de6e6ab/attachment-0001.html