[chirp_devel] [PATCH] [ft4] allow validation of RO frequencies [#6615]

[Dan Smith]

> # HG changeset patch
> # User DanClemmensen <DanClemmensen at gmail.com>
> # Date 1553532256 25200
> #      Mon Mar 25 09:44:16 2019 -0700
> # Node ID 034168b01eceb10301f04dd8596c03aa1267099f
> # Parent  936bffe5c76c85e7dd626c448b0e9031d274235c
> [ft4] allow validation of RO frequencies [#6615]
> Fixes: #6615
> This change to the UI does not implement any RO changes. It
> permits a river to implement such a change.
> 
> diff -r 936bffe5c76c -r 034168b01ece chirp/ui/memedit.py
> --- a/chirp/ui/memedit.py	Tue Mar 19 12:58:02 2019 -0700
> +++ b/chirp/ui/memedit.py	Mon Mar 25 09:44:16 2019 -0700
> @@ -137,6 +137,9 @@
>         was_filled, prev = self.store.get(iter, self.col("_filled"), colnum)
> 
>         def set_offset(offset):
> +            old_dup = self.store.get(iter, self.col(_("Duplex")))[0]
> +            if old_dup in ["off", "split"]:
> +               return
>             if offset > 0:
>                 dup = "+"
>             elif offset == 0:

I'm confused about what you're trying to do here, and having basically no explanation in the commit message isn't helping. I've read the bug and the reason for re-opening it, but I'm not sure what behavior you're describing. If I use the UV-5R driver, I can set a memory to "off" and it stays that way.

Can you please describe what you're fixing and why? If I have to use your driver and test image to reproduce, please put steps in the bug or something.

--Dan