[chirp_devel] [PATCH] [ft4]rework code for progkeys [#6583]
Dan Smith
Wed Mar 13 07:52:43 PDT 2019
> # don't register the FT-65 in the production version until it is tested
> -# @directory.register
> + at directory.register
Looks like you need to remove the comment as well. Assume you will add this to the wiki when it's merged, right? Also, would you mind putting something in the commit message to indicate that a new radio is (effectively) added here? Right now it looks to just be a refactor or bug fix, but it registers a whole new radio, which is a little obscure.
> class YaesuFT65Radio(YaesuSC35GenericRadio):
> MODEL = "FT-65R"
> _basetype = BASETYPE_FT65
> @@ -1112,6 +1125,8 @@
> class_group_descs = copy.deepcopy(YaesuSC35GenericRadio.group_descriptions)
> add_paramdesc(
> class_group_descs, "misc", ("compander", "Compander", ["OFF", "ON"]))
> + CLASS_SPECIALS = list(SPECIALS) # a shallow copy works here
> + CLASS_SPECIALS[-1] = FT65_PROGS # replace the last entry (P key names)
I'm surprised this even works, but even if it does, it's kinda icky. When you respin for the comment, can you just define FT65_SPECIALS at module scope, get it set properly, and then just assign it here?
Thanks!
--Dan
More information about the chirp_devel
mailing list