[chirp_devel] New Model #6421 TYT TH-350

[Zhaofeng Li]

Hi Dan,

That sounds reasonable to me. I've made a couple of changes to the
UV-B5 driver to make overriding easier, and the revised patchset is
attached to this email.

Thanks,
Zhaofeng Li

On Thu, Jan 31, 2019 at 11:02 AM Dan Smith via chirp_devel
<chirp_devel at intrepid.danplanet.com> wrote:
>
> > Hi Zhaofeng,
> >
> >> Just wrote a driver for TYT TH-350, based on the code for Baofeng
> >> UV-B5. Attached is the patch.
> >
> > How similar is this driver to the UV-B5 itself? In general it's much better to subclass a driver if you have just a few changes. I haven't tried applying this and diff'ing them myself, but wanted to ask you first.
>
> Heh, right after I sent, I re-read your comment that there are more details in the issue. It sounds like there are some differences, but are they just around tone encoding and the clone protocol? If so, those are also easy to subclass and override. If many things are different, then it might make the most sense to just add a whole new driver. I just want to avoid senseless duplication _when_possible_.
>
> Thanks!
>
> --Dan
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: th350.patch
Type: text/x-patch
Size: 13615 bytes
Desc: not available
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20190131/9e947a52/attachment-0001.bin