[chirp_devel] Patch for #7119 BF-888 "Refused to enter programming mode."
Dan Smith
Mon Dec 23 11:15:16 PST 2019
> This change fixes the problem with my two radios, but i can't be sure that its the same problem that the original reporter of the bug has.
>
> I'm a bit concerned about raising the timeout globally. I can't rule out that it has any other consequences,
Yeah, it's not appropriate to change it globally to try to address a problem with one radio. If you look at (many) other drivers, they manipulate the timeout on the serial connection themselves as appropriate (grep '.timeout =' should turn up some examples). The initial timeout we set on the serial connection is really just to have *some* timeout to prevent drivers from blocking forever on the pipe when nothing is responding.
> but at the same time i don't imagine anything depends on a particular serial read timeout.
Well, in a way, your driver apparently does :)
If you want to make a change to the radio-specific driver to address a problem, then that's fine, but please just do it there (in chirp/h777.py in your case). Changing timeout values to solve a problem can often be just moving a symptom around, so it'd be good to have any such patch include details about why the change makes sense in the commit message.
Thanks!
--Dan
More information about the chirp_devel
mailing list