[chirp_devel] [PATCH] Fixing issue where KGUV8D Plus did not allow savinng memories with certain valid tuning steps

[Derek Chauran]

Oh, yeah, I was following the doc sequentially and got to the mail part before I got to the patch guidelines, oops. Issue #7021
________________________________
From: chirp_devel-bounces at intrepid.danplanet.com <chirp_devel-bounces at intrepid.danplanet.com> on behalf of Tony Fuller via chirp_devel <chirp_devel at intrepid.danplanet.com>
Sent: Tuesday, August 27, 2019 7:43 PM
To: chirp_devel at intrepid.danplanet.com <chirp_devel at intrepid.danplanet.com>
Subject: Re: [chirp_devel] [PATCH] Fixing issue where KGUV8D Plus did not allow savinng memories with certain valid tuning steps

I stand corrected. I missed the "plus" in the filename. :) I'm guessing the only thing the patch needs is an issue but will go ahead and listen now instead of talking (and looking silly)

Tony

Get Outlook for Android<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Faka.ms%2Fghei36&data=02%7C01%7C%7Cdfc9f42b6bf74a8c212608d72b618d1d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637025570288536918&sdata=3vgMaJKBEGepbUy5QYePkJsEGTfGyUezmkK%2ByhtpvXA%3D&reserved=0>

________________________________
From: Tony Fuller
Sent: Tuesday, August 27, 2019 9:38:13 PM
To: chirp_devel at intrepid.danplanet.com <chirp_devel at intrepid.danplanet.com>
Subject: Re: [chirp_devel] [PATCH] Fixing issue where KGUV8D Plus did not allow savinng memories with certain valid tuning steps

It looks like something very similar was merged in about 5 months ago in https://chirp.danplanet.com/projects/chirp/repository/revisions/2ae5aef78c2e<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fchirp.danplanet.com%2Fprojects%2Fchirp%2Frepository%2Frevisions%2F2ae5aef78c2e&data=02%7C01%7C%7Cdfc9f42b6bf74a8c212608d72b618d1d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637025570288536918&sdata=1DZfv2z9iJdKFXafw%2BJUekjCwcrpRG7kwNL8qmL%2BtRE%3D&reserved=0> but on line 467 (rather than 519) although the context (3 lines above and below) look quite similar.

Maybe you just need to run hg pull? It's totally possible I missed something too.

Tony

Get Outlook for Android<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Faka.ms%2Fghei36&data=02%7C01%7C%7Cdfc9f42b6bf74a8c212608d72b618d1d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637025570288546926&sdata=7qeRJjXIWY%2FODCN%2BcD%2Bq3xv6l0LZQY8S8JhBvmHCbMk%3D&reserved=0>

________________________________
From: chirp_devel-bounces at intrepid.danplanet.com <chirp_devel-bounces at intrepid.danplanet.com> on behalf of Derek Chauran via chirp_devel <chirp_devel at intrepid.danplanet.com>
Sent: Tuesday, August 27, 2019 8:56:24 PM
To: chirp_devel at intrepid.danplanet.com <chirp_devel at intrepid.danplanet.com>
Subject: [chirp_devel] [PATCH] Fixing issue where KGUV8D Plus did not allow savinng memories with certain valid tuning steps

# HG changeset patch
# User Derek Chauran <af7ux at outlook.com>
# Date 1566956276 25200
#      Tue Aug 27 18:37:56 2019 -0700
# Node ID d5665709c5ec7c0549645d75b955592ab826cc74
# Parent  f2f71d0cd6a9a2eadd18b6315afd6078a6519632
Fixing issue where KGUV8D Plus did not allow savinng memories with certain valid tuning steps.

diff --git a/chirp/drivers/kguv8dplus.py b/chirp/drivers/kguv8dplus.py
--- a/chirp/drivers/kguv8dplus.py
+++ b/chirp/drivers/kguv8dplus.py
@@ -519,6 +519,7 @@
         rf.valid_bands = [(134000000, 175000000),  # supports 2m
                           (400000000, 520000000)]  # supports 70cm
         rf.valid_characters = chirp_common.CHARSET_ASCII
+        rf.valid_tuning_steps = STEPS
         rf.memory_bounds = (1, 999)  # 999 memories
         return rf

_______________________________________________
chirp_devel mailing list
chirp_devel at intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel<https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fintrepid.danplanet.com%2Fmailman%2Flistinfo%2Fchirp_devel&data=02%7C01%7C%7Cdfc9f42b6bf74a8c212608d72b618d1d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637025570288546926&sdata=SabxgHlkuAEGqXOeRfxwoF%2FCyBox%2FIo6dXLuQhCri38%3D&reserved=0>
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers<https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fchirp.danplanet.com%2Fprojects%2Fchirp%2Fwiki%2FDevelopers&data=02%7C01%7C%7Cdfc9f42b6bf74a8c212608d72b618d1d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637025570288556939&sdata=kTPt7RXqzLKXM%2BsxK7cTJnHEs9el3Cw2v9RVLVr0qQQ%3D&reserved=0>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20190828/b5c570ba/attachment-0001.html