[chirp_devel] [h777] Enable sidekey configuration for Radioddity GA-2S

Dan Smith
Fri Aug 16 16:15:13 PDT 2019


> Thanks for the quick reply. Here goes #3. I tested it out with my GA-2S 
> by downloading as both a GA-2S and also downloading as a Baofeng 888 in
> separate tabs and the settings menu looks to be correct.

Cool, that looks better, except:

> @@ -618,9 +618,10 @@
>     VENDOR = "Radioddity"
>     MODEL = "GA-2S"
>     _has_fm = False
> -    _has_sidekey = False
> +    SIDEKEYFUNCTION_LIST = ["Off", "Monitor", "Unused", "Alarm"]
> 
>     @classmethod
>     def match_model(cls, filedata, filename):
>         # This model is only ever matched via metadata
>         return False
> +

You're adding random space here. But, I'll let it slide :)

Also note that your mailer wrapped all the long lines, which ruins the diff. I hand edited it to make it apply, but if you're going to send more you might check out the patchbomb extension so you can email straight from hg.

Thanks!

--Dan




More information about the chirp_devel mailing list