[chirp_devel] New Driver patch status?
Dan Smith
Thu Mar 8 06:17:41 PST 2018
> Any status on the Baojie BJ-218 new driver patch submitted 2/21 for issue #5595?
> I am attaching the patch file again, in case it got lost...
Sorry for the delay. I've been traveling for the last two weeks, and then sick from traveling :(
Your patch doesn't look properly formatted to me, like maybe you did an "hg diff" and then manually added some headers to make it look like an export or something like that.
Here's the process for doing this:
https://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess#Submitting-a-patch
However, I'm more interested in the outcome of Jim's review feedback. If this is just a revision on another model, it should be implemented as such and not just copied from one driver to the other. The latter increases maintenance burden quite a bit, and the drivers are modular to facilitate sharing.
Thanks!
--Dan
More information about the chirp_devel
mailing list