[chirp_devel] chirp_devel Digest, Vol 88, Issue 11

Dan Smith
Thu Aug 30 10:48:43 PDT 2018


>>> +        try: 
>>> +            if ack == CMD_ACK: 
>>> +                exito = True 
>>> +                break 
>>> +        except: 
>>> +            LOG.debug("Attempt #%s, failed, trying again" % i) 
>>> +            pass 
>> I don't think there's anything in this try..except block that can raise, so I would just remove it. 
> 
> No that should stay in there as we do expect to receive an ACK from the radio upon sending TYGRAM to the radio. 

Nothing in the try block can raise any exception. Thus, it's impossible for the LOG.debug (or the pass) line to ever run and should be removed.

> I binary attached it to issue #6063 

Thanks!

--Da


More information about the chirp_devel mailing list