[chirp_devel] [PATCH] Add metadata blob trailer transparently to image files

[Tom Hayward]

On Mon, Aug 6, 2018 at 3:14 PM Dan Smith via chirp_devel
<chirp_devel at intrepid.danplanet.com> wrote:
>
> > # HG changeset patch
> > # User Dan Smith <dsmith at danplanet.com>
> > # Date 1533593320 25200
> > #      Mon Aug 06 15:08:40 2018 -0700
> > # Node ID e8d26a9a98c56c6a8bed7967b6b2e089f9ac0b33
> > # Parent  4f6978a84b3e461b13c6e0f996d3bec058431b70
> > Add metadata blob trailer transparently to image files
>
> Looking for feedback and/or testing on this if anyone is interested.

LGTM! I know you have been kicking around this idea for a long time
and it's nice to see it come to fruition.

Thing is, I've always referred to my favorite repeater as
"chirp-img0001-", and that's how I label it in my radios. I hope your
new feature can support my unique use case.

> It should be fairly straightforward, but because it causes chirp to start generating images in a format that older versions won't open, I think it's worth extra eyes to make sure it's sound. If anyone thinks we need to go to extra effort to allow saving in the old format specifically, please speak up.

Changing the file extension seems like a pretty low cost way to
support both formats and allow mere mortals to identify them in a
directory. I can't think of a use case though... Pros? Cons?

Tom