[chirp_devel] revert #4687

[SASANO Takayoshi]

Hello,

>> # HG changeset patch
>> # User SASANO Takayoshi <uaa at mx5.nisiq.net>
>> # Date 1504671405 -32400
>> #      Wed Sep 06 13:16:45 2017 +0900
>> # Node ID 046007af2cb248ae8933f78d5f14dd55b8ae9ee8
>> # Parent  c56244c58fe85688ef0da20a3f7bfebc0f447e6c
>> revert #4687
>> Different from OpenBSD-6.0, OpenBSD-6.1 is no longer required this modification.
>> And, this cause #5007 bug. Revert to 2715:d1bc2c917785.
>
>Sorry for the delay in getting to this. However, I’m not sure I understand what this has to do with OpenBSD. Can you explain a little more?
>
>―Dan
>
>Hi. I never saw an answer from Sasano-san, so I thought I would take a stab. I
>have nothing directly to do with #4697, but I did encounter #5007 (sync
>broken with ID-51's) which was caused by the fix to 4697.
>
>#4697 was an attempt to fix sync errors on OpenBSD with Icom radios, by
>discarding the echo-back of commands. There must be some race condition
>in the fix (or different types of cables, some without echoback), since others
>did not find Sasano-san's problem. Eventually an update to Openbsd seems to
>have fixed Sasano-san's problem without the patch contained in #4697, so he
>asked it to be reverted.
>
>I'm hoping you can merge this patch reversion, since 'stock' chirp remains
>broken for my ID-51 with the patch present.
>
>Let me know if you have any questions.

I tried to run CHIRP on OpenBSD-6.0/amd64, and it need discarding
the echoback to avoid hang-up when cloning. With OpenBSD-6.1 and
recently released OpenBSD-6.2, CHIRP without fix #4687 works.
And fix #4687 causes bug #5007, it is enough reason to revert.

-- 
SASANO Takayoshi (JG1UAA) <uaa at mx5.nisiq.net>