[chirp_devel] [PATCH][tk270.py] Increase OEM band edges by +/- 4.0%, fix #4709

[Tom Hayward]

On Wed, May 3, 2017 at 11:02 AM, Pavel Milanes Costa via chirp_devel
<chirp_devel at intrepid.danplanet.com> wrote:
>               'It has a limited set of features, but the most used by hams.\n'

How about something like "Not all features have been implemented, but it has
those features most used by hams."

> +             'All of this radios are able to work a little off the OEM '
> +             'frequency limits, by experimentation we set it at +/- 4%, '
> +             'that must allow you to work the ham bands in some models.\n'

"The radio is able to work slightly outside the OEM frequency limit. After
testing, the limit in Chirp has been set 4% outside the OEM limit. This
allows you to use some models on the ham bands."

> +             'Nevertheless, each radio has it\'s own hardware limits and as '
> +             'usual your mileage may vary.\n'

"its own", no apostrophe needed.

> -            self._range = [low * 1000000, high * 1000000]
> +
> +            # Frequency ranges: some model/variants are able to work the near
> +            # ham bands, even if they are outside the OEM ranges.
> +            # By experimentation we found that a +/- 4% at the edges is in most
> +            # cases safe and will cover the near ham band in full
> +            self._range = [low * 1000000 * 0.96, high * 1000000 * 1.04]
>
>              # put the VARIANT in the class, clean the model / CHs / Type
>              # in the same layout as the KPG program
>              self._VARIANT = self.MODEL + " [" + str(self._upper) + "CH]: "
>              self._VARIANT += self._kind + ", "
> +            # In the OEM string we show the real OEM ranges
>              self._VARIANT += str(self._range[0]/1000000) + "-"
>              self._VARIANT += str(self._range[1]/1000000) + " Mhz"

You added a comment that the OEM string shows the original range, but you use
the variables you just modified. To print the original, you need:

self._VARIANT += "%d-%d MHz" % (low, high)


The other drivers have the same issues. I don't have time to comment on those
right now. You could make these changes to all of them and resubmit, or wait
and I'll finish my review of the others when I have a chance.

Tom KD7LXL