[chirp_devel] Edge test doesn't match input validation

Tom Hayward
Wed Mar 29 09:51:03 PDT 2017


Recent changes to the TH-D72 driver cause the Edges test to fail. I
looked into it and found an inconsistency between the edge test and
all the other valid_bands logic in Chirp. The issue is described in
this bug report:

http://chirp.danplanet.com/issues/4689

I tried fixing the test by subtracting the minimum step size from the
upper bound, since Chirp's input logic requires a frequency to be less
than the upper bound to be valid. This causes a number of tests to
fail because the drivers don't specify
RadioFeatures.valid_tuning_steps. If this approach is valid, those
drivers will need to be fixed. At least the TH-D72 test passes. ;-)

Comments?

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_edges.log
Type: text/x-log
Size: 6030 bytes
Desc: not available
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20170329/42687dd1/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: edges_test_high_bound.patch
Type: text/x-patch
Size: 914 bytes
Desc: not available
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20170329/42687dd1/attachment-0003.bin 


More information about the chirp_devel mailing list