[chirp_devel] [PATCH] [leixen ] [ 1 of 2 ] 2nd try... prepare for multiple models

[Dan Smith]

> I've re-created this patch against the current tip, but I don't
> *think* there's any difference... it applies and passes tests on my
> repo.

The problem is your mailer is wrapping long lines and breaking the diff.
For example:

> @@ -934,9 +935,7 @@
>      @classmethod
>      def match_model(cls, filedata, filename):
>          if filedata[0x168:0x170].startswith(cls._file_ident) and \
> -                               filedata[0x170:0x178].startswith("LX-\x89\x85"):
> -            return True
> -        elif filedata[0x900:0x906] == cls.MODEL:
> +
> filedata[0x170:0x178].startswith(cls._model_ident):

^ See the wrapped line which breaks the format ^.

If you could attach them as text/plain that would be better, or at least
attach them as binary (although this is less useful). Ideally, you'd use
the patchbomb extension that actually sends the emails itself which
ensures they're in proper format.

I hand-edited both of these patches to fix the issues so I could apply
them this time.

Thanks!

--Dan