[chirp_devel] [PATCH] [leixen] Support non-standard tones on VV898 radio memories

Dan Smith
Wed Aug 31 14:53:15 PDT 2016


Hi Brian,

> This issue used to cause some download corruption when a radio memory
> had one of the non-standard tones (as the factory image did). Note that
> there is no RadioFeatures "valid tones" map, so these extra tones can
> not currently be selected during new memory creation.

Yeah, this is a bummer. We probably should add it to RadioFeatures in
some way.

> +class LeixenMemory(chirp_common.Memory):
> +    '''Leixen memory which supports non-standard tones and codes'''
> +    def __init__(self):
> +        chirp_common.Memory.__init__(self)
> +
> +        self._valid_map["rtone"] = TONES
> +        self._valid_map["ctone"] = TONES

I don't really like doing this because if another part of the code (say
the import logic) creates a Memory it won't be capable of doing what the
radio is.

For the AnyTone 5888UV a while back I added TONES_EXTRA in chirp_common
and just concat that to the _valid_map. I did that because some radio
drivers use the base list and depend on it being in a specific ordering.

Can we just add the extra tones to that TONES_EXTRA list to solve this?

--Dan



More information about the chirp_devel mailing list