[chirp_devel] Patch Etiquette

[Dan Smith]

> I am working on a driver for the Icom ID-51 Plus radio; Part of adding
> support requires modifying the existing ID-51 (non plus) driver to
> workaround a model detention conflict.  Would you prefer one patch with
> the mod to the ID-51 and the ID-51 Plus support as a second patch, or
> both bundled in one patch?

Well, it's not a problem until you add the new driver, right? And, I
assume the change is small? Given those things, combined is fine. If the
change to the existing stuff is really invasive (can't imagine why) then
separate is probably better. And of course, if separate is better for
you then that's fine.

> I'm also curious if renaming the ID-51A to just ID-51 is considered OK,
> as it's identical to the ID-51E and chirp works with both already (hence
> the "A" leading to confusion.  A = Americas, E= Europe)

Usually the A and E editions use a slightly different model
identification string, which means initiating a clone without an
existing image is not possible. Further they often have different band
edges and stuff. If this is really not the case for the 51, then
dropping the A is fine, but I would expect there are some differences.

--Dan