[chirp_devel] [PATCH 00/11] fix pylint issues

[Zachary T Welch]

This series adds pylint support to the cpep8 scripts, then it starts
fixing the issues that are revealed.  By far, the majority of the
changes involve adding docstrings.

Like the push to become pep8 compliant, the cpep8.py script checks a
blacklist to avoid forcing immediate compliance of the entire tree.

The virtualenv setup in cpep8.sh has been updated to install the extra
pacakges needed (pylint, pyserial, and pygtk to start); however, I
changed it such that the packages are install only when the VENV
directory is first created.  The performance penalty of checking before
every run is too much to bear.  I have an idea for fixing that, but
one step at a time.

I am continuing to tweak the pylintrc file in order to minimize the
amount of useless churn while still maximizing coverage, so current
results from checking the entire tree may look worse than what actually
needs to be fixed.

Zachary T Welch (11):
  Rename .pylintc as tools/cpep8.pylintc (#159)
  Update pylintrc file (#159)
  Add pylint support to cpep8 scripts (#159)
  Fix pylint issues in cpep8.py (#159)
  Fix pylint issues in logger.py (#159)
  Fix pylint issues in __init__.py files (#159)
  Fix pylint issues in settings.py (#159)
  Fix pylint issues in radioreference.py (#159)
  Fix pylint issues with chirp/ files (#159)
  Fix pyinit issues for bitwise_grammar.py (#159)
  Fix pylint issues in bitwise.py (#159)

 .hgignore                               |   1 +
 .pylintrc                               | 308 --------------------------------
 chirp/__init__.py                       |   6 +
 chirp/bandplan.py                       |   7 +
 chirp/bandplan_au.py                    |   3 +
 chirp/bandplan_iaru_r1.py               |   4 +
 chirp/bandplan_iaru_r2.py               |   4 +
 chirp/bandplan_iaru_r3.py               |   4 +
 chirp/bandplan_na.py                    |   4 +
 chirp/bitwise.py                        | 104 ++++++++---
 chirp/bitwise_grammar.py                |  32 +++-
 chirp/detect.py                         |   7 +-
 chirp/drivers/__init__.py               |  20 +++
 chirp/errors.py                         |   4 +
 chirp/logger.py                         |  46 +++--
 chirp/memmap.py                         |   8 +-
 chirp/radioreference.py                 |  16 +-
 chirp/settings.py                       |  26 ++-
 chirp/ui/__init__.py                    |   4 +
 chirp/util.py                           |   4 +
 csvdump/__init__.py                     |   4 +
 tests/__init__.py                       |  18 ++
 tests/unit/__init__.py                  |  18 ++
 tools/{cpep8.manifest => cpep8.lintful} |  25 +--
 tools/cpep8.py                          | 123 +++++++++++--
 pylintrc => tools/cpep8.pylintrc        | 305 ++++++++++++++++++++++---------
 tools/cpep8.sh                          |  12 +-
 27 files changed, 640 insertions(+), 477 deletions(-)
 delete mode 100644 .pylintrc
 copy tools/{cpep8.manifest => cpep8.lintful} (86%)
 copy pylintrc => tools/cpep8.pylintrc (51%)

-- 
1.9.1