[chirp_devel] [PATCH] Slight improvement to memory editor container

[Kosta Arvanitis]

I attached two screenshots to the bug report (before and after);  this does a better job of illustrating the change then I can.
 
http://chirp.danplanet.com/issues/2177
 
Its simply an aesthetic fix and does not alter the behaviour in any way.
 

 
Date: Thu, 15 Jan 2015 15:47:36 -0800
From: dsmith at danplanet.com
To: chirp_devel at intrepid.danplanet.com
Subject: Re: [chirp_devel] [PATCH] Slight improvement to memory editor	container

> # Node ID 310c66295ef033650ae6c4171efbb83f6f425abe
> # Parent  5c8cf7aa6ab3d12598a3eaabf69ffdc074c4bcd2
> [PATCH] Slight improvement to memory editor container
> 
> This change simple encapsulates the memory editor scrolling window in an hbox to allow for smooth transition beteween the controls.
 
In the future, can you please wrap your commit messages at 79 columns?
 
>          sw.show()
> +        hbox.pack_start(sw, 1, 1, 1)
>  
>          self.view.connect("button_press_event", self.click_cb)
>  
> -        return sw
> +        hbox.show()
> +
> +        return hbox
 
I don't understand why this makes anything better (or changes anything
at all for that matter).
 
Can you explain?
 
--Dan
 

_______________________________________________
chirp_devel mailing list
chirp_devel at intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20150115/b48242ee/attachment-0001.html