[chirp_devel] Patch - [FT-60] Feature Request: Memory Bank Support #1945

[Kosta Arvanitis]

I looked over both patches, the look very similar.  


There is also a known bug with the memory bounds on the FT-60 module; it is incorrectly specified to not include the 1000th memory bank.  I have a separate fix for this as well.


In addition there is a bug with the BankEditor which is not inclusive of the memory bounds as well, so it also does not display the 1000th memory bank.  I have a separate fix for this as well.


If its ok with Scott, given there is little diff. between the patches I would prefer to apply the one I submitted last week so that I can also submit the two subsequent patches as well which depend on it.  



-kosta



________________________________
> From: stickpatrick at gmail.com 
> To: chirp_devel at intrepid.danplanet.com 
> Date: Sat, 10 Jan 2015 23:44:28 +0000 
> Subject: [chirp_devel] Re: Patch - [FT-60] Feature Request: Memory Bank 
> Support #1945 
> 
> I'm looking at Kosta's now. I took the same approach as the FT857 and 
> lifted a lot of that code including the cache making it a bit harder to 
> read. I’ll see if there's a perf difference or not. 
> 
> Dan - do you have any intention of using chirp_common.MTOBankModel in 
> the future? Right now it's equivalent to chirp_common.BankModel but 
> seems to be a better description of what's in the FT60 since any memory 
> can be stored in 1 or more banks. 
> 
> Sent from Windows Mail 
> 
> From: Dan Smith<mailto:dsmith at danplanet.com> 
> Sent: ‎Saturday‎, ‎January‎ ‎10‎, ‎2015 ‎3‎:‎43‎ ‎PM 
> To: chirp_devel at intrepid.danplanet.com<mailto:chirp_devel at intrepid.danplanet.com> 
> 
>> Can you guys look at each other's patches and decide which should be 
>> applied? 
> 
> I applied Kosta's patch and it's failing one of the bank tests (see the 
> test report from a few minutes ago). 
> 
> So, I'll revert it and let you guys work out which one should go in. 
> Note that you should be able to run the tests locally and verify that 
> the bank model(s) meet the requirements first. 
> 
> Thanks! 
> 
> --Dan 
> 
> 
> _______________________________________________ chirp_devel mailing 
> list chirp_devel at intrepid.danplanet.com 
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer 
> docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers