[chirp_devel] [PATCH] Attempting to speed up memory editor load times

K. Arvanitis
Thu Feb 26 00:51:52 PST 2015


# HG changeset patch
# User K. Arvanitis <kosta at alumni.uvic.ca>
# Date 1424940360 28800
#      Thu Feb 26 00:46:00 2015 -0800
# Node ID 1eafc00a6e585191d1e4cc85f39067d069dd91a4
# Parent  81465a9a288b84f8fd835ceaaf8e3eb249d5bbd0
Attempting to speed up memory editor load times

It appears that the memory editor is unecessarily attempting to simulatanesuoly
prefetch all memories from the radio twice at startup.

This is causing a somewhat signifigant performance hit as the tree view is
performing a linear search of its store attempting to prevent
duplicate entries (see while loop in set_memory)

As a result the duplicate call to prefill was having no effect other than
forcing a lookup of the treestore and did not appear to have any other
bearing on the application.

Another seperate, but related, improvement would be to increase the overall
performance of the linear search of the treestore.

Bug #2369

diff -r 81465a9a288b -r 1eafc00a6e58 chirpui/memedit.py
--- a/chirpui/memedit.py	Wed Feb 25 08:17:24 2015 -0800
+++ b/chirpui/memedit.py	Thu Feb 26 00:46:00 2015 -0800
@@ -1360,12 +1360,8 @@
 
         self.prefill()
         
-        self.choices["Mode"] = self._features.valid_modes
-
         self.root = vbox
 
-        self.prefill()
-
         # Run low priority jobs to get the rest of the memories
         hi = int(self.hi_limit_adj.get_value())
         for i in range(hi, max+1):



More information about the chirp_devel mailing list