[chirp_devel] [PATCH 2/4] Refactor version display into chirp module (#2343)

Zach Welch
Mon Feb 23 20:43:21 PST 2015


On 02/23/2015 03:27 PM, Dan Smith wrote:
>>   if __name__ == "__main__":
>>   	parser = OptionParser()
>> +        parser.add_option("", "--version", action="callback",
>> +                          callback=print_version, nargs=0,
>> +                          help="Print version and exit")
>
> Looks like you broke the indenting here. I know, Python is weird... :)

In my defense, it appears that the chirp.py indenting is inconsistent. 
My vim settings for this project expanded tabs, which I took to be the 
correct choice (as it appears to be the dominant style in the code). 
However, chirp.py contains lots of tabs, thus the mismatch apparent in 
the above hunk.

Assuming that spaces are to be preferred to tabs, I can create an 
additional patch to convert all tabs to spaces, giving the indentation 
the consistency that it needs.  More generally, does CHIRP have a style 
guide that I can reference?

Cheers,
-- 
Zach Welch
Mandolin Creek Farm
www.mandolincreekfarm.com
farm: 541-453-4131
cell: 541-740-3410



More information about the chirp_devel mailing list