[chirp_devel] [PATCH] Flattening of RadioSettings

Dan Smith
Thu Feb 5 16:28:37 PST 2015


> -from chirp.settings import RadioSettingGroup, RadioSetting
> -from chirp.settings import RadioSettingValueBoolean
> +from chirp.settings import *

Can you please not convert these?

http://stackoverflow.com/questions/2386714/why-is-import-bad

Otherwise, I'm fine with the change in general. I know we've got basic
test coverage on most of these, but did you verify each of the drivers
you touched with the sample images to make sure they're okay? This is a
lot of change across a lot of drivers for a single patch, so I want to
make sure we don't break things.

Thanks!

--Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20150205/2f1dd7c7/attachment-0001.bin 


More information about the chirp_devel mailing list