[chirp_devel] [ts2000] Feature complete TS-2000 driver. Fixes #217

Chucks
Sat Apr 4 18:29:24 PDT 2015


Wrapped up the PEP-8 cleanups as much as possible.  There was one where it
complained about under indenting, but that's nit picking to the extreme.
Caught a few minor issues as well in the process, too.

Charles Stewart
chuckination at gmail.com <ccstewart at gmail.com>

On Wed, Apr 1, 2015 at 1:14 AM, Tom Hayward <tom at tomh.us> wrote:

> On Tue, Mar 31, 2015 at 9:26 PM, Chucks <chuckination at gmail.com> wrote:
> > The __memcache to _memcache change was necessary for the TS2000Radio
> class
> > to be able to access the KenwoodLiveRadio superclass's member variable
> for
> > the subclass's get_memory(), set_memory(), and erase_memory() methods and
> > cannot be reverted without impacting functioning of the driver.  The
> double
> > underscore is analogous to java/C++ private and the single underscore is
> > analogous to protected, and it's part of the python black magic that
> appears
> > stylistic but isn't.  I really hate that particular bit of the language
> > because it does nothing but cause problems, but there's no such thing as
> a
> > language without warts.
>
> Okay, that makes sense. I didn't realize you were accessing this from
> the subclass.
>
> P.S. It's not black magic, just name mangling. You should be able to
> find it at TS2000Radio._KenwoodLiveRadio__memcache, but please don't
> try this :-)
>
> Tom KD7LXL
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20150404/1b5da840/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ts2000-pep8.patch
Type: text/x-patch
Size: 10389 bytes
Desc: not available
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20150404/1b5da840/attachment-0001.bin 


More information about the chirp_devel mailing list