[chirp_devel] Issue #1667 - Support for Wouxun KG-UV8D

[Dan Smith]

Hi Ron,

> Attached is my driver for the Wouxun KG-UV6D.

Has anyone else (Ron, you included) looked at this code and compared it
to others to see if it's an obvious clone of something else? It didn't
appear to be obvious to me. Jim?

> At present this can Download & Upload all 999 memories to the radio and
> will display some of the settings (but not upload new values to the radio).

Thanks for this! Some comments below:

> +	    req = chr(i/256) + chr(i%256) + chr(blocksize)

This is kindof nitish, but can you put spaces around the operators here?
There are several occurrences of this (and the comments below) so I'll
just point each out once and let you find the rest.

> +#
> +# Configuration Settings
> +#

This should be indented to the same level as the code it pertains to.

> +        rs = RadioSetting("ponmsg", "Poweron message",
> +			    RadioSettingValueList(
> +				PONMSG_LIST,
> +				PONMSG_LIST[self._memobj.settings.ponmsg]))
> +	cfg_grp.append(rs)
> +        rs = RadioSetting("voice", "Voice Guide", RadioSettingValueBoolean(
> +			    self._memobj.settings.voice))
> +        cfg_grp.append(rs)
> +        rs = RadioSetting("timeout", "Timeout Timer",
> +			    RadioSettingValueInteger(15, 900, 
> +				self._memobj.settings.timeout * 15, 15))
> +        cfg_grp.append(rs)
> +	rs = RadioSetting("toalarm", "Timeout Alarm",
> +			    RadioSettingValueInteger(0, 10,
> +				self._memobj.settings.toalarm))
> +	cfg_grp.append(rs)
> +	rs = RadioSetting("channel_menu", "Menu available in channel mode",
> +			    RadioSettingValueBoolean(
> +				self._memobj.settings.channel_menu))
> +	cfg_grp.append(rs)
> +        rs = RadioSetting("power_save", "Power save",
> +			    RadioSettingValueBoolean(
> +				self._memobj.settings.power_save))
> +        cfg_grp.append(rs)

Looks like some alignment issues here. Just to be clear, each indent
level should be four spaces.

Again, thanks a lot. This looks really close and I'll be glad to get
this into the tree soon!

--Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 538 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20140925/ab09604e/attachment-0001.bin