[chirp_devel] I'd like to add some features to the developer tools

[Tom Hayward]

I'm not sure I understand everything you're suggesting. If you have
already implemented this, can send the changes in patch format so I
can try them myself?

Most of the time, I like having full context in the memory diff. It's
not like it's very long.
I don't understand why a negative channel number was chosen to enable
this feature. Wouldn't a checkbox be more appropriate?

Can you read the font size from the operating system default? I think
this is the appropriate way to do it, but I don't know specifics.
Ability to override this is reasonable, but maybe the problem is that
you have your OS configured the way you like and Chirp isn't honoring
it. That sounds more critical than implementing a font size override.

These sound like a number of small, atomic features. Each distinct
feature should be its own patch and we can discuss it independently if
needed. If one feature is dependent on another, just make sure the
order of your patches is appropriate.

Tom KD7LXL

On Tue, Jun 3, 2014 at 8:21 PM,  <chirp.cordless at xoxy.net> wrote:
> Now that a build is available incorporating the changes I submitted
> in April, so I don't feel like I'm trying to hit a moving target, my
> intention is to move forward with the FT-60 feature settings
> memory map project I started on several months ago.
>
> I have some extensions to the developer's tools I've added to make
> that easier for me, and I expect probably at least some would be
> useful to others. I've been hacking them in to whatever source base
> I'm working with, and was about to again, but I think it's time to see
> if I can just get them into the main codebase once and for all.
>
> Pretty much ready to go, and stable for several months. But I
> don't want to open a bug if this will be received negatively.
> In almost all cases, default behavior is unchanged, and where it's
> not, the differences are trivial and benign. Here's the feature list:
>
> ====================
> Changed the title of the hex dump window from "Differences" to
> a string similar to the one printed to debug.log, showing the
> two file names and memory numbers. Cleaned up an unmatched
> trailing ')' in that print in the process of making this change.
>
> Added a feature to display _only_ different lines in the hex dump,
> controlled by setting the first memory # to -2.
>
> Added some help text to the "Diff Radios" dialog explaining the
> hex dumps available with mem # = -1 and -2.
>
> Added user control of the font size for both the hex dump and the
> Browser (separately). Controlled by new chirp.config integer properties
> diff_fontsize and browser_fontsize in new [developer] section.
> Defaults are unchanged at 11 and 10, respectively.
>
> Added hexdump_addrfmt string property to the [developer] section
> accepting values of hex, decimal, and both. The default remains decimal.
>
> Added diff_charflag boolean property to the [developer] section.
> When True, an additional line is printed after each pair of -/+
> diff lines, with a '^' in each character position, other than the first,
> where the lines are different, blank otherwise. Default is False.
>
> Added hexdump_linesize integer property to the [developer] section
> accepting values of 8 and 16. The default remains 8.
>
> Added an extra " " between every group of 4 bytes in the hex dump.
> ====================
> The source changes aren't extensive, but they're spread over 4 files:
> common.py
> mainapp.py
> radiobrowser.py
> util.py
>
> Shall I move forward with this?
>
> -dan
>
>
>
>
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers