[chirp_devel] [PATCH] Allow specification of the hexdump address format

[chirp.cordless at xoxy.net]

On Jul 18, 2014, at 7:58 AM, Dan Smith - dsmith at danplanet.com wrote:
> # HG changeset patch
> ...

Sorry, I'm going to need some help here. First time doing this.
I cloned a brand-new repository from d-rats.com.
Saved your patch as a text file. The first line is
# HG changeset patch
the last line is
            else:

Looks right to me. But I must be missing something, because I get
================
dan[chirp.hg]$ hg import ~/Desktop/dsmith.patch.txt 
applying /Users/dan/Desktop/dsmith.patch.txt
patching file README.developers
Hunk #1 FAILED at 18
Hunk #2 FAILED at 39
2 out of 2 hunks FAILED -- saving rejects to file README.developers.rej
patching file chirp/util.py
Hunk #1 FAILED at 14
1 out of 1 hunks FAILED -- saving rejects to file chirp/util.py.rej
patching file chirpui/config.py
Hunk #1 FAILED at 35
Hunk #2 FAILED at 64
2 out of 2 hunks FAILED -- saving rejects to file chirpui/config.py.rej
patching file chirpui/mainapp.py
Hunk #1 FAILED at 223
1 out of 1 hunks FAILED -- saving rejects to file chirpui/mainapp.py.rej
abort: patch failed to apply
================

To save some back-and-forth:
I'm guessing the patch works for me, but I'd like to test it.

I can give some feedback on the README file by reading
the raw patch:
- It wouldn't be obvious to me that I can have multiple conversion
  specs, so an example of:
	"hexdump_addrfmt = %(addr)03i 0x%(addr)04x
	prints the address in both decimal and hex"
would be useful.

- The fact that %(addr)03i is the default should be stated.

- The first line of the description is intended to be syntax.
> +hexdump_addrfmt = %(addr)03i
is not syntax, it's an example.
This should be something like
hexdump_addrfmt = <python format specification string>

Looking for help on the patch apply.

-dan