[chirp_devel] [PATCH] fix bad cable errors for some users on upload #1397 (2)

Dan Smith
Wed Feb 5 16:50:03 PST 2014


> -
> -        if prompts.open_port_before_upload_prompt == True:
> -            print "Opening port before pre_upload prompt."
> +        
> +        if prompts.open_port_before_upload_prompt == False:
> +            print "Opening port after pre_upload prompt."
>              self._show_instructions(radio, prompts.pre_upload)

I'm confused. This looks wrong to me. "If open_before is False, then
open (before)"

> -        if prompts.open_port_before_upload_prompt == False:
> -            print "Opening port after pre_upload prompt."
> +        if prompts.open_port_before_upload_prompt == True:
> +            print "Opening port before pre_upload prompt."
>              self._show_instructions(radio, prompts.pre_upload)

"If open_before is true, then open (after)".

Didn't you have it right the first time?

--Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20140205/f19789ff/attachment-0001.bin 


More information about the chirp_devel mailing list