[chirp_devel] [PATCH] [BF-888] Fix BCL and Scramble editing

[Dan Smith]

> # HG changeset patch
> # User Marco Filippi <iz3gme.marco at gmail.com>
> # Date 1397146285 -7200
> #      gio apr 10 18:11:25 2014 +0200
> # Node ID 4cbfbc162073e56aba852c01ffeb7799bf8c8339
> # Parent  c5cf3c72377a8dc151d06f08a23a22ec800971cf
> [BF-888] Fix BCL and Scramble editing
> 
> Fix #1549

Can we have a little more detail here? :)

>          for setting in mem.extra:
>              # NOTE: Only two settings right now, both are inverted
> -            setattr(_mem, setting.get_name(), not setting.value)
> +            setattr(_mem, setting.get_name(), 0 if setting.value == 1 else 1)

When coerced to an integer, this is the same as what was there before,
AFAICT. I assume there was some obscure reason for making this change,
so I think it'd be nice to have it in the commit message for the
future... :)

Thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20140412/d3103adb/attachment-0001.bin