[chirp_devel] [FT-60] Chirp should check parity on download - Fixes 1547

[Dan Smith]

> Patch and test results attached.

Thanks!

> diff -r c5cf3c72377a -r 1cc897a1d161 chirp/ft60.py
> --- a/chirp/ft60.py	Thu Apr 03 16:54:50 2014 +0200
> +++ b/chirp/ft60.py	Wed Apr 09 20:30:12 2014 -0700
> @@ -219,6 +219,9 @@
>          except Exception, e:
>              raise errors.RadioError("Failed to communicate with radio: %s" % e)
>          self.process_mmap()
> +        # Uncomment to simulate a parity error to observe behavior:
> +        #self._memobj.checksum = (self._memobj.checksum + 1) % 256
> +        self.check_checksums()

This looks like an obvious thing we should be doing. However, I'd rather
not have the commented-out code in the tree. If we want to validate that
it works, we should have a test case that mocks out something so that
the checksum fails.

Can you re-spin this with just the check_checksums() line?

Thanks!

--Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20140412/786a6e4e/attachment-0001.bin