[chirp_devel] Patch for issue 1155: chirpw crashes on "pyver.split" on OpenSuSE 11.4
Dan Smith
Sun Sep 29 16:13:11 PDT 2013
> +# sys.hexversion could be used, but requires parsing, has endian dependence, only in python >= 1.52, ....
This isn't necessary (and is too long) so please remove it from the patch.
> + vrel = 0 # arbitrarily assign release index of zero if there's no field for it in pyver
This line is too long (> 79 cols) and the comment that makes it too long
is stating the obvious, so I would just nix it.
Otherwise it looks fine. If you can fix those up and resubmit, I'll
apply. Thanks!
--
Dan Smith
www.danplanet.com
KK7DS
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20130929/7ece72e6/attachment-0001.bin
More information about the chirp_devel
mailing list