[chirp_devel] [PATCH 4 of 4] [ft8x7] Add messages to help users remember clone procedure
Marco IZ3GME
Tue Oct 8 09:43:31 PDT 2013
Hi Tom
> I don't think this is the best place to print the instructions. There
> should be an intermediary step so that the clone does not timeout
> while they are reading instructions. It could be added just after the
> experimental driver warning. In fact, the experimental driver warning
> code is almost exactly what we need, but without the Yes/No prompt.
Well ... I do prefer messages that do not force me to press one more
"ok" every time.
In my opinion the right place would be the upload/download dialog itself
so users can read instructions before to start clone process but this
would involve changes to the dialog to display the correct message at
every radio model change. Nothing I can do in the little time I have
today ;)
>
>> + if blocks == 0:
>> + raise Exception(_("Radio did not ack first block\n")
>> + + self._START_CLONE_RX_MSG)
>
> This never prints because the first iteration of the loop is blocks ==
> 1. Again, it would be more useful to display the instructions prior to
> starting the clone loop.
blocks start from 0 and is incremented only after receiving a good ACK.
Anyway I'm pretty sure that while testing I saw each message for each of
the patch I sent, don't you?
73 de IZ3GME Marco
More information about the chirp_devel
mailing list