[chirp_devel] [PATCH 1 of 2] bitwise: add signed integer support

IZ3GME Marco
Thu May 9 23:44:46 PDT 2013


Hi Dan

>> +#  i8   foo;     /* Signed 8-bit value                      */
>> +#  i16  foo;     /* Signed 16-bit value                     */
>> +#  il16 foo;     /* Signed 16-bit value (LE)                */
>> +#  i24  foo;     /* Signed 24-bit value                     */
>> +#  il24 foo;     /* Signed 24-bit value (LE)                */
>> +#  i32  foo;     /* Signed 32-bit value                     */
>> +#  il32 foo;     /* Signed 32-bit value (LE)                */
>
> What is the choice of using 'i' here? For 'integer'? I think 's' for
> 'signed' would make more sense to me. What do you think?

Well ... 'i' is for integer as in printf where 'u' is for unsigned int 
(same as % operator in python pre PEP-237)

I prefere 'i' but if your choise is 's' I don't mind.

>
>> -
>> +
>
> You added whitespace here :)

You are allowed to delete it ;)

73 de IZ3GME Marco




More information about the chirp_devel mailing list