[chirp_devel] [PATCH 1 of 3] [id31] Backport ID-51 mode logic to ID-31. Related to #553

Dan Smith
Thu Feb 21 18:42:09 PST 2013


> One issue I see with your ID-31 code is that you never clear the bits
> for AM. These should never be set, but if we're going to attempt
> setting the mode we need to set all the relevant bits, even if some of
> them are zeros. Dean's indexed method does this best, so I backported
> the concept to ID-31 (but changed the implementation).

Sure, but at the time, I didn't know them to be for AM :)
 
> If we need to hide AM on ID-31, maybe both radios need to be based on
> an IDx1Radio so that each can have independent mode lists.

Or just make the '51 add AM to the mix in get_features() and use that
list for the index in get/set_memory(). Either way.

-- 
Dan Smith
www.danplanet.com
KK7DS
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20130221/e98f4e27/attachment-0001.bin 


More information about the chirp_devel mailing list