[chirp_devel] [PATCH 1 of 3] [id31] Backport ID-51 mode logic to ID-31. Related to #553

[Tom Hayward]

On Thu, Feb 21, 2013 at 4:12 PM, Dan Smith <dsmith at danplanet.com> wrote:
>> +MODES = {0: "FM", 1: "NFM", 3: "AM", 5: "DV"}
>
> The ID-31A is UHF only, and thus has no support for AM. That's why I
> had it the way I had it, although I'm fine making it indexed to better
> mesh with the ID-51A code (until/unless we find that they used that
> middle bit for something :)

One issue I see with your ID-31 code is that you never clear the bits
for AM. These should never be set, but if we're going to attempt
setting the mode we need to set all the relevant bits, even if some of
them are zeros. Dean's indexed method does this best, so I backported
the concept to ID-31 (but changed the implementation).

If we need to hide AM on ID-31, maybe both radios need to be based on
an IDx1Radio so that each can have independent mode lists.

Tom KD7LXL