[chirp_devel] #553 Icom ID-51 support

[Dean Gibson AE7Q]

Another reason I didn't submit the id31.py changes as a patch is that 
there was no bug # for it.  I will create one, once I know there is a 
definite issue.

And, I've just found out that the patch I submitted for the ID-31 
probably doesn't even compile (I can't tell, without a test).  So, 
remove that from my previous patch submission.  I won't submit a new 
patch for the id31.py unless I've tested it in the test suite.  The only 
reason I submitted it previously, is for you to look at the changes 
BEFORE I formally submitted a patch, which is what I thought you wanted.

-- Dean

On 2013-02-19 08:27, Dean Gibson AE7Q wrote:
>
> So, that's what I did.  "hg status -mar" only shows the id31.py 
> changes, which I'm not ready (per above) to submit yet.  I included 
> the complete id51.py file in my previous eMail so you could see the 
> differences (via the two diffs) before I formally submitted a patch.
>
> So, just now I did "hg add chirp/id51.py", and now "hg status -mar" 
> shows the id51.py.  I then did "hg diff" and got the output shown at 
> the bottom of this eMail.  Note that the diff does not (yet) include 
> adding the D-Star tag field into the "mycall" structure in id31.py;  
> that needs to be verified as needed (98% guess it's needed).
>
>>> I didn't use the one in tests/images because there isn't one.
>> There is, but I suppose you're using a tarball snapshot which perhaps
>> doesn't have it:
>>
>> % ls tests/images/Icom_ID-31A.img -l
>> -rw-r--r-- 1 dan dan 86K May  6  2012 tests/images/Icom_ID-31A.img
>
>
> No, I did a "hg clone http://d-rats.com/hg/chirp.hg" I got lots of 
> test files, but none for the ID-31.  When I ran the tests, it ran one 
> for the ID-51 (I suppose because I had an image file there -- the test 
> passed), but none for the ID-31.
>
> hg diff:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20130219/962b9d99/attachment-0001.html