[chirp_devel] [PATCH] [uv5r] add workmode vfo presets

[Dan Smith]

> # HG changeset patch
> # User Jim Unroe <rock.unroe at gmail.com>
> # Date 1359934996 18000
> # Node ID f6ef3fde290991edb31f13f4cdb03370cb0955bb
> # Parent  41b8c8a428c3136a49ba9742b79752a6f764602d
> [uv5r] add workmode vfo presets
> #467

This was quite an undertaking.. Thanks for doing it :)

> diff -r 41b8c8a428c3 -r f6ef3fde2909 chirp/settings.py
> --- a/chirp/settings.py	Mon Jan 28 20:30:01 2013 -0500
> +++ b/chirp/settings.py	Sun Feb 03 18:43:16 2013 -0500

So, I had intended for the patch that I sent with the UI stuff to go in
separately. It's much nicer for the version history if patches and
changesets are small and self-contained. Since the UI stuff is not
exactly small and also not specific to the UV5, I'd prefer it to be
separate.

That being said, I understand if it's harder for you to slice it up at
this point. If you don't want to, and don't mind, I might try to do
that before I apply the patch.

> @@ -644,7 +644,7 @@
>              return int(version_tag[idx:idx+3])
>          raise Exception("Unrecognized firmware version string")
>  
> -    def _get_settings(self):
> +    def get_settings(self):

You reverted one of my changes here, probably because I made it while
you were working on this and it got merged into your patch without you
realizing it. It would be good if you could avoid this, which may just
be a bit of manual tweaking so that the code after your patch looks
like the code before (minus your changes).

The patch was:

http://chirp.danplanet.com/projects/chirp/repository/revisions/5f4fff6266ab/diff

> +        val1a = RadioSettingValueInteger(13600000, 52000000,

I know this isn't what you want to do, but at least it works. Maybe we
should leave it as-is and I can help you make it format like a float
after we get the core functionality into the tree.

Otherwise, I think it looks good.

Seriously, what's left to do? When can we start making fun of the folks
that still use the icky OEM software? :)

-- 
Dan Smith
www.danplanet.com
KK7DS
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20130205/031b22f0/attachment-0001.bin