[chirp_devel] [PATCH 0 of 2] Style checks and consistent tests

Michael Pittaro
Tue Dec 3 06:05:12 PST 2013


On Mon, Dec 2, 2013 at 1:47 PM, Dan Smith <dsmith at danplanet.com> wrote:
> This set adds two things:
>
> 1. A strict(er) set of style checks for a given patch. This will enforce
> <80 column lines for all files touched in a patch. This will avoid failing
> on everything right now, but any patch that touches a file will need to
> fix all the lines. This is a nice ideal, but I'm not sure how other folks
> feel about it. This check also verifies the bug number in the commit
> message, etc. I'd like this to be a "does this meet style requirements"
> hook for people to run before submitting a patch.
>
> 2. A top-level test function that runs everything we have, to maybe help
> avoid what happened recently, where the unit tests passed, but the driver
> tests did not.
>
> If folks like this, I'll make jenkins run all of this on each build.

This makes sense to me, I don't see a problem with using it.

mike



More information about the chirp_devel mailing list