[chirp_devel] [PATCH 1 of 2] Add rx_dtcs and additional tone/dtcs modes support in UI

[Dan Smith]

> +    "Tone->",

Why do we need this? A tmode of "Tone" should be "transmit tone, but
don't require one" which is what "Tone->" implies.

> +    "DTCS Enc",

What's this? The case where we transmit but don't require a DTCS code
should be covered under the already-present "DTCS->" cross mode, right?

>          "dtcs"          : DTCS_CODES + DTCS_EXTRA_CODES,
> +        "rx_dtcs"          : DTCS_CODES + DTCS_EXTRA_CODES,
>          "tmode"         : TONE_MODES,

Can you keep that aligned?

>          (_("DTCS Code") , TYPE_INT,     gtk.CellRendererCombo, ),
> +        (_("DTCS Rx Code") , TYPE_INT,     gtk.CellRendererCombo, ),
>          (_("DTCS Pol")  , TYPE_STRING,  gtk.CellRendererCombo, ),

This too.

>          _("DTCS Code") : 23,
> +        _("DTCS Rx Code") : 23,
>          _("DTCS Pol")  : "NN",

And this.

Thanks Marco!

-- 
Dan Smith
www.danplanet.com
KK7DS

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20120522/e19d1ddf/attachment-0001.bin