[chirp_devel] Review: IC-T7H support

[Dan Smith]

> Updated patch with copyright changes and hg export format. I've also
> attached an image file from my T7H.

Cool, thanks.

> Tests are failing like crazy, I think because of fractional frequencies,
> which AFAIK the T7H doesn't support. I'll take a look later this week.

Yep, see below.

> +STEPS =  [5.0, 10.0, 12.5, 15.0, 20.0, 25.0, 30.0, 50.0]

<snip>

> +    def get_features(self):
> +        rf = chirp_common.RadioFeatures()
> +        rf.memory_bounds = (0, 59)
> +        rf.valid_modes = list(MODES)
> +        rf.valid_tmodes = list(TMODES)
> +        rf.valid_duplexes = list(DUPLEX)
> +        rf.valid_bands = [( 30000000,  823995000),
> +                          (849000000,  868995000),
> +                          (894000000, 1309995000)]

One of the tests is trying to set the claimed top-end frequency of
1309MHz and getting back 309MHz. If the radio really supports this, then
something isn't right in the driver to store/fetch that value.

> +        rf.valid_skips = ["", "S"]

You define STEPS above, but don't tell CHIRP what they are. If you do
that, then the tests won't try to set frequencies that require 6.25 and
12.5 kHz steps. This will cause all of the tests (other than the one
mentioned above) to pass.

> +        rf.has_tuning_step = False

Note that all Icoms I've ever seen store the tuning step in the memory
channels. I don't know why they do this (other than to support tuning
off of a memory) but they do. It's fine if that one doesn't, or if you
don't want to support it, but all of the other Icom drivers do, just FYI.

Thanks!

-- 
Dan Smith
www.danplanet.com
KK7DS



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20120717/cfbffe44/attachment-0001.bin