[chirp_devel] [PATCH] Allow editing name and comment in import dialog. Feature #150

Dan Smith
Wed Apr 25 10:19:16 PDT 2012


> Allow editing name and comment in import dialog. Feature #150

Nice, applied, thanks.

> +        elif col == self.col_name or col == self.col_comm:

Just a comment... in cases like this, I like to do the following instead:

  elif col in [self.col_name, self.col_comm]:

just because I think it's easier to read, it's shorter, and because it's
easier to add another case if/when necessary.

No need to change, of course, as your way is perfectly fine, I just
wanted to say that :)

-- 
Dan Smith
www.danplanet.com
KK7DS

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20120425/814fb407/attachment-0001.bin 


More information about the chirp_devel mailing list