[chirp_devel] [PATCH 2 of 2] Add import from RadioReference.com. Feature #114

Dan Smith
Tue Apr 10 15:38:38 PDT 2012


> # HG changeset patch
> # User Tom Hayward <tom at tomh.us>
> # Date 1334073630 21600
> # Node ID 309d2038f31cf7e5137990c889ba4a6ca98ef321
> # Parent  806b80ebe58e7d62f62ee9d6e9ab0fc929236e49
> Add import from RadioReference.com. Feature #114

Sweet.

When I run against 97124, I get:

> -- Exception: --
> Traceback (most recent call last):
>   File "/home/dan/chirp/chirpui/editorset.py", line 270, in do_import
>     self.rthread)
>   File "/home/dan/chirp/chirpui/editorset.py", line 214, in _do_import_locked
>     dialog = dlgclass(src_radio, dst_rthread.radio, self.parent_window)
>   File "/home/dan/chirp/chirpui/importdialog.py", line 594, in __init__
>     self.populate_list()
>   File "/home/dan/chirp/chirpui/importdialog.py", line 516, in populate_list
>     msgs = self.dst_radio.validate_memory(mem)
>   File "/home/dan/chirp/chirp/chirp_common.py", line 908, in validate_memory
>     for char in mem.name:
> TypeError: 'NoneType' object is not iterable
> ------

I did see it fetching a bunch of categories and stuff in the console though.

It takes almost as long to fetch my zipcode as it does to do a simple
RFinder query. Granted, it's doing a LOT more than RFinder, but it still
causes my window to dim. Since it's fetching things, we should work on
trying to make a throbbing progress bar of some sort. With RFinder,
we're just waiting for a single http request to complete, so we don't
have anything to drive a throbber naturally, but I think we can do
better for this. It doesn't need to gate inclusion, but is something to
think about, perhaps in one of your follow-on patches.

> +        mem.freq = int(freq.out * 1000 * 1000)

You will want to use chirp_common.parse_freq() here, which takes care
not to propagate the inevitable error to be had by storing the
frequencies in IEEE floating point format. Otherwise, you'll get some
issues with 6.25kHz (at least) channels here.

I'll get going on trying to get suds into the windows runtime (ugh).

-- 
Dan Smith
www.danplanet.com
KK7DS

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20120410/afe4e80c/attachment-0001.bin 


More information about the chirp_devel mailing list